Skip to content

fix: rename rhtas deployment name #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: rename rhtas deployment name #129

wants to merge 1 commit into from

Conversation

@osmman
Copy link
Contributor

@osmman osmman commented May 14, 2025 •
edited by sourcery-ai bot
Loading

Change RHTAS operator deployment name to rhtas-controller-manager which has been caused because of cahnges in immutable sections which causes OLM upgrade to fail.

Refs: securesign/secure-sign-operator#1110

Summary by Sourcery

Rename RHTAS operator deployment references in installation tasks to 'rhtas-controller-manager' to fix OLM upgrade failures.

Bug Fixes:

  • Update deployment name in tasks/install-operator-from-fbc.yaml to use 'rhtas-controller-manager' for get and wait commands.
  • Update deployment name in tasks/install-operator-from-image.yaml to use 'rhtas-controller-manager' for wait command.

@osmman
fix: rename rhtas deployment name
fbf4312 
Change RHTAS operator deployment name to rhtas-controller-manager which has been
caused because of cahnges in immutable sections which causes OLM upgrade to fail.

Refs: securesign/secure-sign-operator#1110
@sourcery-ai
Copy link

sourcery-ai bot commented May 14, 2025 •
edited
Loading

Reviewer's Guide

Rename references to the RHTAS operator deployment from "rhtas-operator-controller-manager" to "rhtas-controller-manager" in installation task scripts to ensure OLM upgrades succeed.

File-Level Changes

Change Details Files
Update deployment name in FBC-based install script
  • Changed the "oc get deployment" invocation to use the new name
  • Updated the "oc wait --for=condition=available" command to reference the new deployment name
 tasks/install-operator-from-fbc.yaml
Update deployment name in image-based install script
  • Adjusted the "oc wait --for=condition=available" command to use the new deployment name
 tasks/install-operator-from-image.yaml
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@osmman osmman mentioned this pull request May 14, 2025
Draft
sourcery-ai[bot]
sourcery-ai bot reviewed May 14, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @osmman - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@osmman osmman requested a review from bouskaJ May 14, 2025 09:06
@osmman osmman marked this pull request as draft June 18, 2025 13:27
@osmman osmman closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@bouskaJ bouskaJ Awaiting requested review from bouskaJ

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@osmman